Skip to content

Run format and analyze on presubmit/postsubmit #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2021
Merged

Run format and analyze on presubmit/postsubmit #275

merged 5 commits into from
Nov 9, 2021

Conversation

CaseyHillers
Copy link
Collaborator

@CaseyHillers CaseyHillers commented Oct 29, 2021 •
edited
Loading

I'm working on another PR, and noticed that all the tests that were passing or failing.

  • Created github action for presubmit + postsubmit (run format and analyze)
    • Fix some lints, and generate mocks for null safety
  • Created an integration test directory (this will require generating a secret to run against the github api)
  • Disabled unit tests and integration tests until they can be fixed (hopefully we can parallelize fixing the tests)

@CaseyHillers CaseyHillers mentioned this pull request Oct 29, 2021
Closed
@CaseyHillers
Copy link
Collaborator Author

\cc @kevmoo @robbecker-wf FYI - I'll try working on this, but I won't have much time next week to fix this. I'm going to rollback my package to 8.2.1. The tests are all failing even though the github check shows it as green

@kevmoo
Copy link
Collaborator

kevmoo commented Oct 29, 2021

Cool! Glad someone is looking at it...

@robrbecker
Copy link
Member

When I inherited this project I was unsure about the state of the tests and was warned that some of them ran on live github repos. I haven't ever gotten around to revamping the tests :shame:
I was hoping to use the same testing setup as whatever mock service gets stood up in the octokit repo(s) https://github.com/octokit

@CaseyHillers CaseyHillers changed the title Run tests, format, analyze on presubmit/postsubmit Run format and analyze on presubmit/postsubmit Nov 2, 2021
@CaseyHillers
Copy link
Collaborator Author

When I inherited this project I was unsure about the state of the tests and was warned that some of them ran on live github repos. I haven't ever gotten around to revamping the tests :shame:
I was hoping to use the same testing setup as whatever mock service gets stood up in the octokit repo(s) https://github.com/octokit

I'll have to take a look! I think it's reasonable to get the integration tests working, but I'm not familiar with what octokit is doing

@CaseyHillers CaseyHillers marked this pull request as ready for review November 2, 2021 18:51
@CaseyHillers
Copy link
Collaborator Author

@robrbecker I simplified this to just enable format and analyze to start screening PRs

@CaseyHillers CaseyHillers requested a review from kevmoo November 8, 2021 23:45
@kevmoo kevmoo merged commit 57dd829 into SpinlockLabs:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo Awaiting requested review from kevmoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyHillers @kevmoo @robrbecker
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy