Skip to content

Make GitHub.auth non-nullable #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2023
Merged

Make GitHub.auth non-nullable #377

merged 4 commits into from
Jun 20, 2023

Conversation

CaseyHillers
Copy link
Collaborator

For the most part, this is already non-nullable.

See flutter/flutter#129134 - This should help with debugging why our server is getting a null auth state.

@CaseyHillers CaseyHillers added the semver:minor Non-Breaking Public API Changes (additions) label Jun 20, 2023
@CaseyHillers CaseyHillers mentioned this pull request Jun 20, 2023
Closed
@kevmoo
Copy link
Collaborator

kevmoo commented Jun 20, 2023

We'll want a changelog entry here, right?

@CaseyHillers
Copy link
Collaborator Author

We'll want a changelog entry here, right?

Changelog entries are generated by the GitHub action

@kevmoo kevmoo merged commit c07c634 into SpinlockLabs:master Jun 20, 2023
@CaseyHillers
Copy link
Collaborator Author

@robbecker-wf can you help release this? \cc @ricardoamador

@robrbecker
Copy link
Member

Released in version 9.15.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.15.0

@srawlins srawlins mentioned this pull request Jun 21, 2023
Closed
@Hixie
Copy link
Contributor

Hixie commented Jun 23, 2023

I don't mind making this non-nullable, but can we restore making it mutable? GitHub credentials regularly need to be refreshed and having to recreate a whole new GitHub object each time is more annoying that just giving the existing object a new authentication token.

@CaseyHillers
Copy link
Collaborator Author

I don't mind making this non-nullable, but can we restore making it mutable?

Out of curiosity, do you have sample code I could take a look at? This seems like a fair request, but I was under the impression most callers will recreate the entire client instead of re-minting the auth.

@CaseyHillers CaseyHillers mentioned this pull request Jun 26, 2023
Merged
@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2023

https://github.com/Hixie/cocoon/blob/9b487e12dab09c2eb396ce9aa9b5ee4a76991756/triage_bot/lib/engine.dart#L1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@robrbecker robrbecker Awaiting requested review from robrbecker

Assignees
No one assigned
Labels
semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyHillers @kevmoo @robrbecker @Hixie
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy