Skip to content

More robust [code] parsing #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2018
Merged

More robust [code] parsing #2868

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb1558
More robust code parsing
andrewaikens87 Sep 15, 2018
77e58e9
fix code class
andrewaikens87 Sep 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions site/app/views/forum/ForumThreadView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,13 +703,8 @@ public function filter_post_content($original_post_content) {
//end link handling

//handle converting code segments
$post_content = preg_replace('/&lbrack;code&rsqb;(.*?)&lbrack;&sol;code&rsqb;/', '<textarea id="code">$1</textarea>', $post_content);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing this, you should also change the id="code" to use a class so that pages with multiple code blocks are valid html.


$codeBracketString = "&lbrack;&sol;code&rsqb;";
if(strpos($post_content, "&NewLine;&lbrack;&sol;code&rsqb;") !== false){
$codeBracketString = "&NewLine;" . $codeBracketString;
}

$post_content = str_replace($codeBracketString, '</textarea>', str_replace('&lbrack;code&rsqb;', '<textarea id="code">', $post_content));
return $post_content;
}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy