Skip to content

[BugFix:TAGrading] Fix text annotation #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 21, 2022
Merged

[BugFix:TAGrading] Fix text annotation #534

merged 7 commits into from
Jun 21, 2022

Conversation

Eceptonsu
Copy link
Contributor

What is the current behavior?

The text annotation input box does not stay with the cursor consistently.
The text annotation does not show up after finishing entering the text.

What is the new behavior?

The text annotation input box will stay with the cursor.
The text annotation will become visible at the proper location after finishing entering the text.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #534 (b302c2e) into main (905bc5d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   73.73%   73.77%   +0.03%     
==========================================
  Files          38       38              
  Lines        1321     1323       +2     
==========================================
+ Hits          974      976       +2     
  Misses        347      347              

@Eceptonsu Eceptonsu requested a review from Viyerelu23333 June 17, 2022 07:20
Copy link

@Viyerelu23333 Viyerelu23333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on my end and looks good to me. If this PR is ready to be released, consider bumping up the patch version number.

@bmcutler bmcutler merged commit 2089efb into main Jun 21, 2022
@bmcutler bmcutler deleted the Text_annotation branch June 21, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy