[UserBundle] Allow user password to be null for SSO #12441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
approved these changes
Mar 16, 2021
loic425
commented
Mar 17, 2021
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sylius\Bundle\AdminApiBundle\Migrations; |
There was a problem hiding this comment.
@pamil I think this is a wrong namespace (automatically generated).
Sylius\Bundle\UserBundle\Migrations ?
There was a problem hiding this comment.
Oh, that's right! Let's move it to CoreBundle, we only provide migrations there.
pamil
suggested changes
Mar 18, 2021
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sylius\Bundle\AdminApiBundle\Migrations; |
There was a problem hiding this comment.
Oh, that's right! Let's move it to CoreBundle, we only provide migrations there.
pamil
approved these changes
Mar 18, 2021
|
Thank you, Loïc! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a SSO such as Keycloak, you don't need a password. It's better to allow null instead of setting plain password with a random value.
Moreover, password will be decoupled from user interface on Symfony security user.
symfony/symfony#40267