-
Notifications
You must be signed in to change notification settings - Fork 20.1k
Closed as not planned
Description
What would you like to share?
There are probably many classes in this repository, which have some strange design - we should update all of them. I think we can start with cleaning up these:
List of the classes needing redesign:
-
AllPathsFromSourceToTarget
-
ArrayCombination
(refactor: redesignArrayCombination
#5181 by @yuvashreenarayanan3) -
Combination
-
ColumnarTranspositionCipher
-
StringMatchFiniteAutomata
(refactor: redesignStringMatchFiniteAutomata
#5222 by @samuelfac) -
LetterCombinationsOfPhoneNumber
(refactor: redesignLetterCombinationsOfPhoneNumber
#5221 by @samuelfac)
(@siriak, @BamaCharanChhandogi feel free to edit the list above)
Additional information
How to contribute
- select one class form the list above such that no one else is working on (and is not done yet),
- write a comment "Hey, I am working on
XYZ
", whereXYZ
is your selected class, - in your fork, please create a branch like
cleanup_XYZ
, - make your changes and create a pull-request, in which you mention this issue by writing something like "Related to #(this issue number)". Please make sure that you add all necessary tests. If possible, prefer parametrized tests.
Also feel free to suggest a class, which should be added to the list above.
siriak, devXlalit and tarunsharma000