Skip to content

Refactored all the compareTo() to SortUtils functions #6336 #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Refactored all the compareTo() to SortUtils functions #6336 #6433

wants to merge 5 commits into from

Conversation

dinishajais
Copy link

Enhancement #6336

I have refactored and replaced all the compareTo with SortUtil functions. The places where equality is checked or where the code uses the values given by the compareTo() , has not been replaced.

Three files have no changes and the reason is mentioned below:

  1. StrandSort : In this java class the methods in which compareTo is used has <T extends Comparable<? super T>> as the return type. Since the SortUtils functions are declared with <T extends Comparable>, which contradicts. Thus SortUtils functions cannot be used here in this class in any method.
  2. FlashSort : same reason as StrandSort
  3. WiggleSort: This class either has equality or it uses the numerical value given by the compareTo().

Thus apart from above three classes all other classes have been refcatored.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.79498% with 22 lines in your changes missing coverage. Please review.

Project coverage is 75.03%. Comparing base (ec7b654) to head (d87dad6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ava/com/thealgorithms/sorts/IntrospectiveSort.java 56.86% 20 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6433      +/-   ##
============================================
+ Coverage     75.00%   75.03%   +0.03%     
- Complexity     5536     5540       +4     
============================================
  Files           686      686              
  Lines         19214    19214              
  Branches       3708     3708              
============================================
+ Hits          14412    14418       +6     
+ Misses         4245     4241       -4     
+ Partials        557      555       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dinishajais dinishajais deleted the enhancement/#6336-comparision-sortUtils-logic branch July 24, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinishajais @codecov-commenter
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy