Remove duplicate SimpleSort (same logic as ExchangeSort) #6441
+0
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should delete the test class of the Simple sort as well |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6441 +/- ##
============================================
- Coverage 75.03% 75.03% -0.01%
+ Complexity 5540 5535 -5
============================================
Files 686 685 -1
Lines 19214 19208 -6
Branches 3708 3706 -2
============================================
- Hits 14418 14412 -6
Misses 4241 4241
Partials 555 555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
SimpleSort.java, which had an identical implementation toExchangeSort.java.Keeping both caused redundancy in the codebase.
Why ExchangeSort was kept
i < length - 1).compareTo()directly for clarity.Closes #6383