Skip to content

#6438 Improvement of Hamming Distance class #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+132 −22
Open

#6438 Improvement of Hamming Distance class #6447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5423f5
Improvement of Hamming Distance class
dinishajais Jul 27, 2025
46dc663
Added formatting
dinishajais Jul 27, 2025
bd10fa1
Deleting the unnecessary file added by mistake
dinishajais Jul 27, 2025
6ebd704
resolving build issue
dinishajais Jul 27, 2025
0413a60
Reverting back the changes for it seems the formatter in build job is…
dinishajais Jul 27, 2025
ef70986
Merge branch 'master' into 6438/ImprovementForHammingDistance
DenizAltunkapan Jul 27, 2025
086ca72
Formatted acc to clang-format
dinishajais Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Formatted acc to clang-format
  • Loading branch information
@dinishajais
dinishajais committed Jul 27, 2025
commit 086ca72496901afda75429b124349bdfdb44da4d
14 changes: 7 additions & 7 deletions src/main/java/com/thealgorithms/others/cn/HammingDistance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

public final class HammingDistance {

private HammingDistance() {
}
private HammingDistance() {
}

public static int compute(String bitsStrA, String bitsStrB) {
HammingHandler chain = new ValidateBinaryHandler();
chain.setNext(new ValidateLengthHandler()).setNext(new ComputeHammingHandler());
public static int compute(String bitsStrA, String bitsStrB) {
HammingHandler chain = new ValidateBinaryHandler();
chain.setNext(new ValidateLengthHandler()).setNext(new ComputeHammingHandler());

return (int) chain.handle(bitsStrA, bitsStrB);
}
return (int) chain.handle(bitsStrA, bitsStrB);
}
}
6 changes: 2 additions & 4 deletions src/test/java/com/thealgorithms/others/cn/ValidateBinaryHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ public class ValidateBinaryHandlerTest {

@Test
public void validBinaryStringsShouldPass() {
handler.setNext(new MockHammingHandler("PASSED"));
handler.setNext(new MockHammingHandler("PASSED"));
Object result = handler.handle("1010", "0110");
Assertions.assertThat(result).isEqualTo("PASSED");
}

@Test
public void invalidBinaryShouldThrowException() {
Assertions.assertThatThrownBy(() -> handler.handle("10A0", "0110"))
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("binary string");
Assertions.assertThatThrownBy(() -> handler.handle("10A0", "0110")).isInstanceOf(IllegalArgumentException.class).hasMessageContaining("binary string");
}
}
6 changes: 2 additions & 4 deletions src/test/java/com/thealgorithms/others/cn/ValidateLengthHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@ public class ValidateLengthHandlerTest {

@Test
public void validLengthShouldPass() {
handler.setNext(new MockHammingHandler("LENGTH_OK"));
handler.setNext(new MockHammingHandler("LENGTH_OK"));
Object result = handler.handle("1010", "0110");
Assertions.assertThat(result).isEqualTo("LENGTH_OK");
}

@Test
public void mismatchedLengthShouldThrowException() {
Assertions.assertThatThrownBy(() -> handler.handle("101", "10"))
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("same length");
Assertions.assertThatThrownBy(() -> handler.handle("101", "10")).isInstanceOf(IllegalArgumentException.class).hasMessageContaining("same length");
}
}
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy