Add ReverseStringUsingStack utility for reversing strings using stack #6450
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6450 +/- ##
============================================
+ Coverage 75.04% 75.05% +0.01%
- Complexity 5534 5539 +5
============================================
Files 685 686 +1
Lines 19208 19217 +9
Branches 3706 3709 +3
============================================
+ Hits 14414 14424 +10
Misses 4239 4239
+ Partials 555 554 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alxkm
requested changes
Jul 29, 2025
| * @param str string to be reversed using stack | ||
| * @return reversed string | ||
| */ | ||
| public static String reverse(String str) { |
There was a problem hiding this comment.
Will be better to have next check here. And update javadoc that method throw such exception.
if (str == null) {
throw new IllegalArgumentException("Input string cannot be null");
}
| } | ||
|
|
||
| @Test | ||
| void testNullInput() { |
There was a problem hiding this comment.
And remove this test and add this:
@Test
void testNullInput() {
assertThrows(IllegalArgumentException.class, () -> ReverseStringUsingStack.reverse(null));
}
DenizAltunkapan
requested changes
Jul 29, 2025
There was a problem hiding this comment.
I would also suggest moving the method inside the existing ReverseString file, so that all different approaches are in one class to keep the previous approach.
| return str; | ||
| } | ||
| // Push each character of the string onto the stack | ||
| for (char i : str.toCharArray()) { |
There was a problem hiding this comment.
Variable name i in the for-each loop might be misleading, i would rename it to ch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java