Fix GetEuclidGCD #1068
Merged
Fix GetEuclidGCD #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the actual Euclidean Algorithm
|
@appgurueu You forgot to style the code. |
|
This pull request introduces 4 alerts when merging 48021e1 into 7d40bb4 - view on LGTM.com new alerts:
|
|
The triple equals is actually unnecessary due to the type check above... |
|
This pull request introduces 4 alerts when merging 5d5e4e8 into 7d40bb4 - view on LGTM.com new alerts:
|
raklaptudirm
requested changes
Jul 27, 2022
raklaptudirm
approved these changes
Jul 27, 2022
raklaptudirm
added a commit
that referenced
this pull request
Jul 27, 2022
* Fix GetEuclidGCD
Implement the actual Euclidean Algorithm
* Replace == with ===
* Lua > JS
* Standard sucks
* Oops
* Update GetEuclidGCD.js
* Updated Documentation in README.md
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
raklaptudirm
added a commit
that referenced
this pull request
Aug 7, 2022
* Updated Documentation in README.md * merge: Fix GetEuclidGCD (#1068) (#1069) * Fix GetEuclidGCD Implement the actual Euclidean Algorithm * Replace == with === * Lua > JS * Standard sucks * Oops * Update GetEuclidGCD.js * Updated Documentation in README.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> * feat: implement Shor's Algorithm * chore: add tests * Updated Documentation in README.md * chore: fix spelling Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the actual Euclidean Algorithm