Skip to content

Feat: Created matrix search function with test cases #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Feat: Created matrix search function with test cases #1559

wants to merge 1 commit into from

Conversation

developerr-ayush
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@developerr-ayush developerr-ayush marked this pull request as ready for review October 21, 2023 03:31
@developerr-ayush
Copy link
Contributor Author

hey can i get hectoberfest label?

@developerr-ayush
Copy link
Contributor Author

@appgurueu any improvement on this pr?

@developerr-ayush
Copy link
Contributor Author

@appgurueu @raklaptudirm

its been 3 days waiting for your review.

@raklaptudirm
Copy link
Member

@appgurueu I don't think this algorithm provides any more educational information compared to a simple array linear search. What do you think?

@appgurueu
Copy link
Collaborator

@appgurueu I don't think this algorithm provides any more educational information compared to a simple array linear search. What do you think?

Agreed. This is effectively a linear search on the cells of the matrix.

@appgurueu appgurueu closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@developerr-ayush @raklaptudirm @appgurueu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy