Skip to content

OddEvenSort Added #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from May 23, 2021
Merged

OddEvenSort Added #243

merged 1 commit into from May 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2020 •
edited by ghost
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@nandanvasudevan
Copy link
Contributor

nandanvasudevan commented Aug 3, 2020 •
edited
Loading

Test your code

This works.

// > const test = [5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2]
// > const result = [ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
// > oddEvenSort(test)
// > (test.every((val, index) => val === result[index]))
// true

Output

(node:6784) ExperimentalWarning: The ESM module loader is experimental.
running doctests in test.js...
[ 5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2 ]
[ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
.

Weird DocTest behaviour

Can anyone explain why the below doctest passes? Documentation for JavaScript seems poor.
Notice the 399 in the middle.

// > const test = [5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2]
// > oddEvenSort(test)
// test [1,2,2,2,399,5,5,6,7,8,12,14]

The output I get:

(node:6277) ExperimentalWarning: The ESM module loader is experimental.
running doctests in test.js...
[ 5, 6, 7, 8, 1, 2, 12, 14, 5, 3, 2, 2 ]
[ 1, 2, 2, 2, 3, 5, 5, 6, 7, 8, 12, 14 ]
.

I think it's evaluating with test. Is there a syntax I am missing?

klaygueds
klaygueds approved these changes Sep 23, 2020
View reviewed changes
Copy link

@klaygueds klaygueds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Feb 13, 2021
@stale
Copy link

stale bot commented Mar 20, 2021

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Mar 20, 2021
@raklaptudirm raklaptudirm reopened this May 23, 2021
@raklaptudirm raklaptudirm merged commit 931f0e5 into TheAlgorithms:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix Will not be fixed or is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandanvasudevan @klaygueds @raklaptudirm
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy