Skip to content

Fix Maths/IsDivisible #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 23, 2021
Merged

Fix Maths/IsDivisible #597

merged 8 commits into from
May 23, 2021

Conversation

Masa-Shin
Copy link
Contributor

@Masa-Shin Masa-Shin commented May 5, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Masa-Shin added 3 commits May 5, 2021 14:21
@Masa-Shin
Fix case of file name of isDivisible
5a0db06
@Masa-Shin
Improve input validation of isDivisible
469a0e0 
- Use Number.isFinite() for validation
- Throw an error instead of returning a string
- Instead of returning a string, return false when divisor === 0 since no numbers are in fact divisible by 0.
@Masa-Shin
Add tests for Maths/IsDivisible
cf5ff92
raklaptudirm
raklaptudirm requested changes May 13, 2021
View reviewed changes
@raklaptudirm
Copy link
Member

@Masa-Shin I am pinging because it seems you have abandoned this PR.

@Masa-Shin
Copy link
Contributor Author

@raklaptudirm
I will fix it on this weekend thanks.

@pomkarnath98 pomkarnath98 added the feature Adds a new feature label May 22, 2021
@raklaptudirm raklaptudirm added the changes required This pull request needs changes label May 22, 2021
@raklaptudirm raklaptudirm added code style issue Failing style checks and removed changes required This pull request needs changes labels May 23, 2021
@raklaptudirm
Copy link
Member

@Masa-Shin please fix the standard style issues.

@Masa-Shin
Copy link
Contributor Author

@raklaptudirm
sorry I fixed.

@raklaptudirm raklaptudirm merged commit f813ae4 into TheAlgorithms:master May 23, 2021
@raklaptudirm raklaptudirm removed the code style issue Failing style checks label May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Masa-Shin @raklaptudirm @pomkarnath98
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy