Skip to content

consistent list syntax in CONTRIBUTING.md #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2022
Merged

consistent list syntax in CONTRIBUTING.md #921

merged 6 commits into from
Mar 12, 2022

Conversation

akib22
Copy link
Contributor

@akib22 akib22 commented Mar 11, 2022

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Removed extra bullet point.
  • Updated code indentation.
  • Fixed typos.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@akib22 akib22 requested a review from raklaptudirm as a code owner March 11, 2022 16:44
raklaptudirm
raklaptudirm reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akib22 Why is - better than * ?

@akib22
Copy link
Contributor Author

akib22 commented Mar 12, 2022

It's easier to type - than *. That's why I prefer - over *.

I was unsure whether I should replace * with -. Then I saw this pull request then made the change.

raklaptudirm
raklaptudirm approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was mostly merged due to the grammar fix. Though maintaining a consistent syntax is important.

@raklaptudirm raklaptudirm added the feature Adds a new feature label Mar 12, 2022
@raklaptudirm raklaptudirm changed the title Update CONTRIBUTING.md consistent list syntax in CONTRIBUTING.md Mar 12, 2022
@raklaptudirm raklaptudirm merged commit 7f479b8 into TheAlgorithms:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akib22 @raklaptudirm
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy