Improperly implemented water #766
Draft
+4,680
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to figure out why the texture just won't read.
…tching texture dimensions
|
Any updates? |
|
Soon™. I have exams to go through. I wanted to do it properly in a bit from the ground up and closely follow the games water shader. Unless someone else wishes to accelerate this on their own. |
…til proper materials.
# Conflicts: # GUI/Types/Renderer/MeshBatchRenderer.cs # GUI/Types/Renderer/Shaders/water_csgo.frag # GUI/Types/Renderer/Shaders/water_csgo.vert
# Conflicts: # GUI/Types/Renderer/Shaders/water_csgo.frag
uncommented the FramebufferCopy depth blit switched water_csgo.frag over to using the FramebufferCopy textures
removed old Ssr Framebuffer copy added check for being in WorldViewer before taking Framebuffer copy
-General verification against the original -debris coverage is off -lightmaps are not used, reference decompile was from a version without such
-Fixed a bug with edge blending -Fixed a bug with foam sampling UV coordinates
reimplemented changes from framebuffer-copy branch. adjust water to matrix convention change adjusted uniform type
…nd ingame shader quality high. Clean-up and fixes imminent. Added a new helper function to sample the environment cubemaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source2Viewer_E2XVWEKK7I.mp4