Skip to content

Commit 19dc56b

Browse files
authored
chore: remove v8 mentions from docs and ci.yml (typescript-eslint#9747)
1 parent b490098 commit 19dc56b

File tree

5 files changed

+19
-70
lines changed

5 files changed

+19
-70
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches:
66
- main
7-
- v8
87
pull_request:
98
branches:
109
- '**'
@@ -300,36 +299,3 @@ jobs:
300299
NX_CLOUD_DISTRIBUTED_EXECUTION: false
301300
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
302301
NPM_CONFIG_PROVENANCE: true
303-
304-
publish_canary_version_v8:
305-
name: Publish the latest v8 code as a canary version
306-
runs-on: ubuntu-latest
307-
permissions:
308-
id-token: write
309-
needs: [integration_tests, lint_with_build, lint_without_build, unit_tests]
310-
if: github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/v8'
311-
steps:
312-
- name: Checkout
313-
uses: actions/checkout@v4
314-
with:
315-
fetch-depth: 0 # we need the tags to be available
316-
317-
- name: Install
318-
uses: ./.github/actions/prepare-install
319-
with:
320-
node-version: ${{ env.PRIMARY_NODE_VERSION }}
321-
registry-url: 'https://registry.npmjs.org'
322-
323-
- name: Build
324-
uses: ./.github/actions/prepare-build
325-
326-
- name: Figure out and apply the next canary version
327-
run: OVERRIDE_MAJOR_VERSION=8 npx tsx tools/release/apply-canary-version.mts
328-
329-
- name: Publish all packages to npm with the canary tag
330-
# NOTE: this needs to be npx, rather than yarn, to make sure the authenticated npm registry is used
331-
run: npx nx release publish --tag rc-v8 --verbose
332-
env:
333-
NX_CLOUD_DISTRIBUTED_EXECUTION: false
334-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
335-
NPM_CONFIG_PROVENANCE: true

.github/workflows/close-v8-issues.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/website/blog/2024-05-27-announcing-typescript-eslint-v8-beta.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Please do try out the typescript-eslint v8 beta!
3939

4040
### As A New User
4141

42-
If you don't yet use typescript-eslint, you can go through our [configuration steps on the v8 _Getting Started_ docs](https://v8--typescript-eslint.netlify.app/getting-started).
42+
If you don't yet use typescript-eslint, you can go through our [configuration steps on the v8 _Getting Started_ docs](/getting-started).
4343
It'll walk you through setting up typescript-eslint in a project.
4444

4545
To use v8 specifically, see the following section for an updated install command.
@@ -220,13 +220,13 @@ typescript-eslint v8 deletes the `ban-types` rule and replaces it with several m
220220

221221
To migrate to the new rules:
222222

223-
- If you were disabling the ban on `{}`, consider enabling [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type), as it allows some cases of `{}` that were previously banned.
223+
- If you were disabling the ban on `{}`, consider enabling [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type), as it allows some cases of `{}` that were previously banned.
224224
- If you were banning any configurable types lists, provide a similar configuration to [`no-restricted-types`](/rules/no-restricted-types).
225225
- If you have [`@typescript-eslint/ban-types`](/rules/ban-types) manually enabled, it will no longer ban:
226-
- `{}` or `object`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type).
227-
- `Function`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-unsafe-function-type`](https://v8--typescript-eslint.netlify.app/rules/no-unsafe-function-type).
228-
- `Number` or other built-in uppercase types: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-wrapper-object-types`](https://v8--typescript-eslint.netlify.app/rules/no-wrapper-object-types).
229-
- If you have [`@typescript-eslint/no-empty-interface`](/rules/no-empty-interface) manually enabled, remove that, and instead either use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type).
226+
- `{}` or `object`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type).
227+
- `Function`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-unsafe-function-type`](/rules/no-unsafe-function-type).
228+
- `Number` or other built-in uppercase types: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-wrapper-object-types`](/rules/no-wrapper-object-types).
229+
- If you have [`@typescript-eslint/no-empty-interface`](/rules/no-empty-interface) manually enabled, remove that, and instead either use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type).
230230

231231
For more details, see the issues and pull requests that split apart the `ban-types` rule:
232232

packages/website/blog/2024-07-31-announcing-typescript-eslint-v8.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -484,21 +484,21 @@ On the other hand, there are legitimate uses for `{}`, and banning it by default
484484

485485
typescript-eslint v8 deletes the `ban-types` rule and replaces it with several more targeted rules:
486486

487-
- [`@typescript-eslint/no-restricted-types`](https://v8--typescript-eslint.netlify.app/rules/no-restricted-types) is the new rule for banning a configurable list of type names.
487+
- [`@typescript-eslint/no-restricted-types`](/rules/no-restricted-types) is the new rule for banning a configurable list of type names.
488488
It has no options enabled by default.
489-
- [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type) bans the built-in `{}` type in confusing locations.
490-
- [`@typescript-eslint/no-unsafe-function-type`](https://v8--typescript-eslint.netlify.app/rules/no-unsafe-function-type) bans the built-in `Function` type
491-
- [`@typescript-eslint/no-wrapper-object-types`](https://v8--typescript-eslint.netlify.app/rules/no-wrapper-object-types) bans `Object` and built-in class wrappers such as `Number`.
489+
- [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type) bans the built-in `{}` type in confusing locations.
490+
- [`@typescript-eslint/no-unsafe-function-type`](/rules/no-unsafe-function-type) bans the built-in `Function` type
491+
- [`@typescript-eslint/no-wrapper-object-types`](/rules/no-wrapper-object-types) bans `Object` and built-in class wrappers such as `Number`.
492492

493493
To migrate to the new rules:
494494

495-
- If you were disabling the ban on `{}`, consider enabling [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type), as it allows some cases of `{}` that were previously banned.
496-
- If you were banning any configurable types lists, provide a similar configuration to [`no-restricted-types`](https://v8--typescript-eslint.netlify.app/rules/no-restricted-types).
495+
- If you were disabling the ban on `{}`, consider enabling [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type), as it allows some cases of `{}` that were previously banned.
496+
- If you were banning any configurable types lists, provide a similar configuration to [`no-restricted-types`](/rules/no-restricted-types).
497497
- If you have [`@typescript-eslint/ban-types`](/rules/ban-types) manually enabled, it will no longer ban:
498-
- `{}` or `object`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type).
499-
- `Function`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-unsafe-function-type`](https://v8--typescript-eslint.netlify.app/rules/no-unsafe-function-type).
500-
- `Number` or other built-in uppercase types: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-wrapper-object-types`](https://v8--typescript-eslint.netlify.app/rules/no-wrapper-object-types).
501-
- If you have [`@typescript-eslint/no-empty-interface`](/rules/no-empty-interface) manually enabled, remove that, and instead either use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](https://v8--typescript-eslint.netlify.app/rules/no-empty-object-type).
498+
- `{}` or `object`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type).
499+
- `Function`: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-unsafe-function-type`](/rules/no-unsafe-function-type).
500+
- `Number` or other built-in uppercase types: use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-wrapper-object-types`](/rules/no-wrapper-object-types).
501+
- If you have [`@typescript-eslint/no-empty-interface`](/rules/no-empty-interface) manually enabled, remove that, and instead either use a [recommended config](/users/configs) or manually enable [`@typescript-eslint/no-empty-object-type`](/rules/no-empty-object-type).
502502

503503
For more details, see the issues and pull requests that split apart the `ban-types` rule:
504504

packages/website/webpack.plugin.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ module.exports = function (/*context, options*/) {
2121
'process.env.ESLINT_VERSION': JSON.stringify(
2222
require('eslint/package.json').version,
2323
),
24-
// TODO: Move back to package.json's version shortly after v8 launches
25-
'process.env.TS_ESLINT_VERSION': JSON.stringify('v8'),
24+
'process.env.TS_ESLINT_VERSION': JSON.stringify(
25+
require('@typescript-eslint/eslint-plugin/package.json').version,
26+
),
2627
}),
2728
new CopyPlugin({
2829
patterns: [

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy