Skip to content

chore: remove v8 mentions from docs and ci.yml #9747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: remove v8 mentions from docs and ci.yml #9747

merged 1 commit into from
Aug 7, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Aug 7, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit de1e232
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66b32ec988ccfa00083a253e
😎 Deploy Preview https://deploy-preview-9747--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

auvred
auvred commented Aug 7, 2024
View reviewed changes
packages/website/webpack.plugin.js
Comment on lines -24 to +26
// TODO: Move back to package.json's version shortly after v8 launches
'process.env.TS_ESLINT_VERSION': JSON.stringify('v8'),
'process.env.TS_ESLINT_VERSION': JSON.stringify(
require('@typescript-eslint/eslint-plugin/package.json').version,
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting changes made in #9593

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit de1e232. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 7, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 19dc56b into typescript-eslint:main Aug 7, 2024
61 of 62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: remove v8 mentions from docs and ci.yml
3 participants
@auvred @JoshuaKGoldberg @kirkwaiblinger
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy