Skip to content

Respect package.json's engines.node field when used as a node-version-file #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Respect package.json's engines.node field when used as a node-version-file #485

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d279e1
Allow reading 'package.json' as node-version-file
mannie-exe May 6, 2022
57edf6c
Run 'npm run build'
mannie-exe May 6, 2022
f8cdefe
Read package.json contents directly during tests
mannie-exe May 15, 2022
3bf06e2
Run project Prettier 💅
mannie-exe May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run project Prettier 💅
  • Loading branch information
@mannie-exe
mannie-exe authored and Manpreet Singh committed Jul 20, 2022
commit 3bf06e207ba17768f6adb1c35dc69a82ae3a500a
5 changes: 4 additions & 1 deletion __tests__/installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,10 @@ describe('setup-node', () => {

it('reads package.json as node-version-file if provided', async () => {
// Arrange
const versionSpec = fs.readFileSync(path.join(__dirname, 'data/package.json'), 'utf-8');
const versionSpec = fs.readFileSync(
path.join(__dirname, 'data/package.json'),
'utf-8'
);
const versionFile = 'package.json';
const expectedVersionSpec = '14';
process.env['GITHUB_WORKSPACE'] = path.join(__dirname, 'data');
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy