Skip to content

Add test for node-version * #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022
Merged

Add test for node-version * #491

merged 2 commits into from
May 18, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented May 13, 2022

Description:
This PR only adds test coverage for existing behavior: It adds a unit and e2e test for node-version *.

What I did was:

  • Combine the following three tests with it.each(table) --- but I'm happy to leave them unrolled if you prefer?
  • Added a new row for testing *:
    it.each([
      ['12.16.2', 'darwin', '12.16.2', 'Erbium'],
      ['12', 'linux', '12.16.2', 'Erbium'],
      ['10', 'win32', '10.20.1', 'Dubnium'],
      ['*', 'linux', '14.0.0', 'Fermium'] // <- Added a new row
    ])(
      'can find %s from manifest on %s',
      async (versionSpec, platform, expectedVersion, expectedLts) => {
  • Added an e2e test for node-version *.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@jablko jablko requested a review from a team May 13, 2022 23:06
@dmitry-shibanov
Copy link
Contributor

Hello @jablko. Thank you for your pull request. I think only unit tests will be enough.

@jablko
Copy link
Contributor Author

jablko commented May 16, 2022

@dmitry-shibanov dmitry-shibanov merged commit 4d62faf into actions:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy