Skip to content

Fix error node version output #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Fix error node version output #540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aab7cc8
add silent
dmitry-shibanov Jul 12, 2022
48de4c1
change to streams
dmitry-shibanov Jul 12, 2022
28ad38f
add try catch
dmitry-shibanov Jul 12, 2022
072a2e3
add trim and silent true
dmitry-shibanov Jul 12, 2022
3d11add
remove unused import
dmitry-shibanov Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add trim and silent true
  • Loading branch information
@dmitry-shibanov
dmitry-shibanov committed Jul 12, 2022
commit 072a2e3b100f5d9394c602616700b044ce5e72f8
4 changes: 2 additions & 2 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71847,8 +71847,8 @@ function run() {
}
// Output version of node is being used
try {
const { stdout: installedVersion } = yield exec.getExecOutput('node', ['--version'], { ignoreReturnCode: true, silent: false });
core.setOutput('node-version', installedVersion);
const { stdout: installedVersion } = yield exec.getExecOutput('node', ['--version'], { ignoreReturnCode: true, silent: true });
core.setOutput('node-version', installedVersion.trim());
}
catch (err) {
core.setOutput('node-version', '');
Expand Down
5 changes: 3 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as core from '@actions/core';
import * as exec from '@actions/exec';
import * as installer from './installer';
import fs from 'fs';
import * as child_process from 'child_process';
import * as auth from './authutil';
import * as path from 'path';
import {restoreCache} from './cache-restore';
Expand Down Expand Up @@ -45,9 +46,9 @@ export async function run() {
const {stdout: installedVersion} = await exec.getExecOutput(
'node',
['--version'],
{ignoreReturnCode: true, silent: false}
{ignoreReturnCode: true, silent: true}
);
core.setOutput('node-version', installedVersion);
core.setOutput('node-version', installedVersion.trim());
} catch (err) {
core.setOutput('node-version', '');
}
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy