Skip to content

Add overflow checks for int to bytes conversions #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 10, 2019
Merged

Add overflow checks for int to bytes conversions #1860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e041df7
Add tests for overflows converting ints to bytes
May 9, 2019
095c844
Add overflow checks for int to bytes conversions
May 9, 2019
f325bd8
Use OverflowError exception type for overflows
May 9, 2019
fb7bb40
Update translations
May 9, 2019
1d0c616
Reverse int to bytes buffer overflow conditionals
May 10, 2019
80a752d
Merge latest adafruit/master in.
tannewt May 10, 2019
1d7a49d
Merge remote-tracking branch 'adafruit/master' into int_to_bytes_over…
tannewt May 10, 2019
6700728
Tighten down inlining on the pIRkey
tannewt May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions locale/ID.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2019-05-08 15:23-0700\n"
"POT-Creation-Date: 2019-05-09 01:06-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down Expand Up @@ -52,8 +52,8 @@ msgstr ""
msgid "%q indices must be integers, not %s"
msgstr ""

#: shared-bindings/bleio/CharacteristicBuffer.c
#: shared-bindings/displayio/Group.c shared-bindings/displayio/Shape.c
#: shared-bindings/bleio/CharacteristicBuffer.c
#, fuzzy
msgid "%q must be >= 1"
msgstr "buffers harus mempunyai panjang yang sama"
Expand Down Expand Up @@ -253,8 +253,8 @@ msgstr "Semua channel event yang disinkronisasi sedang digunakan"
msgid "All timers for this pin are in use"
msgstr "Semua timer untuk pin ini sedang digunakan"

#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/pulseio/PulseOut.c
#: ports/nrf/common-hal/pulseio/PulseOut.c shared-bindings/pulseio/PWMOut.c
#: shared-module/_pew/PewPew.c
Expand Down Expand Up @@ -751,8 +751,8 @@ msgstr ""
msgid "Input/output error"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Invalid %q pin"
msgstr "%q pada tidak valid"

Expand Down Expand Up @@ -1076,8 +1076,8 @@ msgstr ""
msgid "Sample rate too high. It must be less than %d"
msgstr "Nilai sampel terlalu tinggi. Nilai harus kurang dari %d"

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Serializer in use"
msgstr "Serializer sedang digunakan"

Expand Down Expand Up @@ -1216,8 +1216,8 @@ msgstr ""
msgid "Unable to allocate buffers for signed conversion"
msgstr "Tidak dapat mengalokasikan buffer untuk signed conversion"

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Unable to find free GCLK"
msgstr "Tidak dapat menemukan GCLK yang kosong"

Expand Down Expand Up @@ -1709,7 +1709,7 @@ msgstr ""
msgid "empty"
msgstr ""

#: extmod/moduheapq.c extmod/modutimeq.c
#: extmod/modutimeq.c extmod/moduheapq.c
msgid "empty heap"
msgstr "heap kosong"

Expand Down Expand Up @@ -2586,6 +2586,11 @@ msgstr ""
msgid "unsupported types for %q: '%s', '%s'"
msgstr ""

#: py/objint.c
#, c-format
msgid "value would overflow a %d byte buffer"
msgstr ""

#: shared-bindings/displayio/Bitmap.c
msgid "value_count must be > 0"
msgstr ""
Expand Down
7 changes: 6 additions & 1 deletion locale/circuitpython.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2019-05-08 15:23-0700\n"
"POT-Creation-Date: 2019-05-10 10:09-0700\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down Expand Up @@ -2539,6 +2539,11 @@ msgstr ""
msgid "unsupported types for %q: '%s', '%s'"
msgstr ""

#: py/objint.c
#, c-format
msgid "value would overflow a %d byte buffer"
msgstr ""

#: shared-bindings/displayio/Bitmap.c
msgid "value_count must be > 0"
msgstr ""
Expand Down
19 changes: 12 additions & 7 deletions locale/de_DE.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2019-05-08 15:23-0700\n"
"POT-Creation-Date: 2019-05-09 01:06-0400\n"
"PO-Revision-Date: 2018-07-27 11:55-0700\n"
"Last-Translator: Pascal Deneaux\n"
"Language-Team: Sebastian Plamauer, Pascal Deneaux\n"
Expand Down Expand Up @@ -54,8 +54,8 @@ msgstr "Der Index %q befindet sich außerhalb der Reihung"
msgid "%q indices must be integers, not %s"
msgstr "%q Indizes müssen ganze Zahlen sein, nicht %s"

#: shared-bindings/bleio/CharacteristicBuffer.c
#: shared-bindings/displayio/Group.c shared-bindings/displayio/Shape.c
#: shared-bindings/bleio/CharacteristicBuffer.c
msgid "%q must be >= 1"
msgstr "%q muss >= 1 sein"

Expand Down Expand Up @@ -253,8 +253,8 @@ msgstr "Alle sync event Kanäle werden benutzt"
msgid "All timers for this pin are in use"
msgstr "Alle timer für diesen Pin werden bereits benutzt"

#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/pulseio/PulseOut.c
#: ports/nrf/common-hal/pulseio/PulseOut.c shared-bindings/pulseio/PWMOut.c
#: shared-module/_pew/PewPew.c
Expand Down Expand Up @@ -732,8 +732,8 @@ msgstr ""
msgid "Input/output error"
msgstr "Eingabe-/Ausgabefehler"

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Invalid %q pin"
msgstr "Ungültiger %q pin"

Expand Down Expand Up @@ -1063,8 +1063,8 @@ msgstr "Abtastrate muss positiv sein"
msgid "Sample rate too high. It must be less than %d"
msgstr "Abtastrate zu hoch. Wert muss unter %d liegen"

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Serializer in use"
msgstr "Serializer wird benutzt"

Expand Down Expand Up @@ -1212,8 +1212,8 @@ msgstr "Der UUID-Wert ist kein str-, int- oder Byte-Puffer"
msgid "Unable to allocate buffers for signed conversion"
msgstr "Konnte keine Buffer für Vorzeichenumwandlung allozieren"

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Unable to find free GCLK"
msgstr "Konnte keinen freien GCLK finden"

Expand Down Expand Up @@ -1705,7 +1705,7 @@ msgstr "Division durch Null"
msgid "empty"
msgstr "leer"

#: extmod/moduheapq.c extmod/modutimeq.c
#: extmod/modutimeq.c extmod/moduheapq.c
msgid "empty heap"
msgstr "leerer heap"

Expand Down Expand Up @@ -2595,6 +2595,11 @@ msgstr "nicht unterstützter Typ für Operator"
msgid "unsupported types for %q: '%s', '%s'"
msgstr "nicht unterstützte Typen für %q: '%s', '%s'"

#: py/objint.c
#, c-format
msgid "value would overflow a %d byte buffer"
msgstr ""

#: shared-bindings/displayio/Bitmap.c
msgid "value_count must be > 0"
msgstr ""
Expand Down
19 changes: 12 additions & 7 deletions locale/en_US.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2019-05-08 15:23-0700\n"
"POT-Creation-Date: 2019-05-09 01:06-0400\n"
"PO-Revision-Date: 2018-07-27 11:55-0700\n"
"Last-Translator: \n"
"Language-Team: \n"
Expand Down Expand Up @@ -52,8 +52,8 @@ msgstr ""
msgid "%q indices must be integers, not %s"
msgstr ""

#: shared-bindings/bleio/CharacteristicBuffer.c
#: shared-bindings/displayio/Group.c shared-bindings/displayio/Shape.c
#: shared-bindings/bleio/CharacteristicBuffer.c
msgid "%q must be >= 1"
msgstr ""

Expand Down Expand Up @@ -251,8 +251,8 @@ msgstr ""
msgid "All timers for this pin are in use"
msgstr ""

#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/pulseio/PulseOut.c
#: ports/nrf/common-hal/pulseio/PulseOut.c shared-bindings/pulseio/PWMOut.c
#: shared-module/_pew/PewPew.c
Expand Down Expand Up @@ -726,8 +726,8 @@ msgstr ""
msgid "Input/output error"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Invalid %q pin"
msgstr ""

Expand Down Expand Up @@ -1046,8 +1046,8 @@ msgstr ""
msgid "Sample rate too high. It must be less than %d"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Serializer in use"
msgstr ""

Expand Down Expand Up @@ -1183,8 +1183,8 @@ msgstr ""
msgid "Unable to allocate buffers for signed conversion"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Unable to find free GCLK"
msgstr ""

Expand Down Expand Up @@ -1665,7 +1665,7 @@ msgstr ""
msgid "empty"
msgstr ""

#: extmod/moduheapq.c extmod/modutimeq.c
#: extmod/modutimeq.c extmod/moduheapq.c
msgid "empty heap"
msgstr ""

Expand Down Expand Up @@ -2539,6 +2539,11 @@ msgstr ""
msgid "unsupported types for %q: '%s', '%s'"
msgstr ""

#: py/objint.c
#, c-format
msgid "value would overflow a %d byte buffer"
msgstr ""

#: shared-bindings/displayio/Bitmap.c
msgid "value_count must be > 0"
msgstr ""
Expand Down
19 changes: 12 additions & 7 deletions locale/en_x_pirate.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2019-05-08 15:23-0700\n"
"POT-Creation-Date: 2019-05-09 01:06-0400\n"
"PO-Revision-Date: 2018-07-27 11:55-0700\n"
"Last-Translator: \n"
"Language-Team: @sommersoft, @MrCertainly\n"
Expand Down Expand Up @@ -54,8 +54,8 @@ msgstr ""
msgid "%q indices must be integers, not %s"
msgstr ""

#: shared-bindings/bleio/CharacteristicBuffer.c
#: shared-bindings/displayio/Group.c shared-bindings/displayio/Shape.c
#: shared-bindings/bleio/CharacteristicBuffer.c
msgid "%q must be >= 1"
msgstr ""

Expand Down Expand Up @@ -253,8 +253,8 @@ msgstr ""
msgid "All timers for this pin are in use"
msgstr ""

#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
#: ports/atmel-samd/common-hal/audioio/AudioOut.c
#: ports/atmel-samd/common-hal/pulseio/PulseOut.c
#: ports/nrf/common-hal/pulseio/PulseOut.c shared-bindings/pulseio/PWMOut.c
#: shared-module/_pew/PewPew.c
Expand Down Expand Up @@ -730,8 +730,8 @@ msgstr ""
msgid "Input/output error"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Invalid %q pin"
msgstr "Avast! %q pin be invalid"

Expand Down Expand Up @@ -1050,8 +1050,8 @@ msgstr ""
msgid "Sample rate too high. It must be less than %d"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Serializer in use"
msgstr ""

Expand Down Expand Up @@ -1187,8 +1187,8 @@ msgstr ""
msgid "Unable to allocate buffers for signed conversion"
msgstr ""

#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
#: ports/atmel-samd/common-hal/audiobusio/PDMIn.c
#: ports/atmel-samd/common-hal/audiobusio/I2SOut.c
msgid "Unable to find free GCLK"
msgstr "Arr! No free GCLK be in sight"

Expand Down Expand Up @@ -1669,7 +1669,7 @@ msgstr ""
msgid "empty"
msgstr ""

#: extmod/moduheapq.c extmod/modutimeq.c
#: extmod/modutimeq.c extmod/moduheapq.c
msgid "empty heap"
msgstr ""

Expand Down Expand Up @@ -2543,6 +2543,11 @@ msgstr ""
msgid "unsupported types for %q: '%s', '%s'"
msgstr ""

#: py/objint.c
#, c-format
msgid "value would overflow a %d byte buffer"
msgstr ""

#: shared-bindings/displayio/Bitmap.c
msgid "value_count must be > 0"
msgstr ""
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy