Skip to content

Merge in gamepadshift fix to master. #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

Merge in gamepadshift fix to master. #1943

merged 2 commits into from
Jun 13, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jun 13, 2019

No description provided.

deshipu and others added 2 commits June 12, 2019 11:42
@deshipu @tannewt
When clearing gamepad buffer, use the last button state, not 0
5e265f4 
When reading the accumulated button presses in gamepad and gamepadshift,
don't clear the buffer to "no buttons pressed", but instead set it to
the current (last checked) state. This clears the accumulated presses,
but retains any ongoing ones.

This fixes #1935
@tannewt
Merge pull request #1939 from pewpew-game/gamepad-clear
076a3f8 
When clearing gamepad buffer, use the last button state, not 0
@tannewt tannewt requested a review from dhalbert June 13, 2019 18:37
dhalbert
dhalbert approved these changes Jun 13, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping master up to date.

@tannewt tannewt merged commit 6d388a3 into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @dhalbert @deshipu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy