Skip to content

STM32: rename feather_stm32f405_express, fix makefile defs issue #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2019
Merged

STM32: rename feather_stm32f405_express, fix makefile defs issue #2243

merged 1 commit into from
Oct 24, 2019

Conversation

hierophect
Copy link
Collaborator

This PR changes the Feather for the F405 to use a clearer name, matching it with its aws bucket. It also removes a tinyusb makefile define that was quietly overriding the frequency of the feather and pyboard, which has been fixed in upcoming PRs but should probably go live ASAP.

@hierophect hierophect added the stm label Oct 24, 2019
@ladyada ladyada requested a review from dhalbert October 24, 2019 16:55
@hierophect
Copy link
Collaborator Author

hierophect commented Oct 24, 2019 •
edited
Loading

We should let CI run on this before merging, sometimes it gets huffy about changes to the yml. I don't think I missed anything this time, though.

@ladyada
Copy link
Member

ladyada commented Oct 24, 2019

yep dont merge till it passes!

@dhalbert
Copy link
Collaborator

It also removes a tinyusb makefile define that was quietly overriding the frequency of the feather and pyboard, which has been fixed in upcoming PRs but should probably go live ASAP.

I am not sure what you mean by this. Do you mean it's fixed in some upcoming PR's of yours, or in tinyusb?

@hierophect
Copy link
Collaborator Author

@dhalbert in the tusb makefile defines (which were one of the first things added to the port) there was this line -DHSE_VALUE=8000000 which I guess was in there because tusb examples don't use the HAL_CONF file that's standard for most STM32 implementations. This was quietly overriding the HAL value and messing up a lot of frequency stuff, but it doesn't explicitly break anything until you start using UART and PWM.

I've included it here since support for the feather and pyboard is a little more "official" now and I don't want people encountering the wrong frequency if PWM somehow takes a long time to merge.

@hierophect
Copy link
Collaborator Author

hierophect commented Oct 24, 2019 •
edited
Loading

Actually, hal conf is in the BSPs for tusb... I'm not sure why Thach puts this override in all his makefiles.

@dhalbert
Copy link
Collaborator

Actually, it is in the BSPs for tusb... I'm not sure why Thach puts it in all his makefiles.

Would be fine to ask that in a tinyusb issue.

dhalbert
dhalbert approved these changes Oct 24, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hierophect hierophect merged commit 3683ee3 into adafruit:master Oct 24, 2019
@hierophect hierophect deleted the f405-rename-and-fixes branch October 24, 2019 18:11
@dhalbert
Copy link
Collaborator

I tapped "Merge" on my phone, not sure why it didn't merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
stm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hierophect @ladyada @dhalbert
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy