Increase stack size in 4.1.x (by a hair more than in 5.0) #2399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. this is the first increase I tried, and it worked. A smaller increase might be OK.
|
I tried the smallest increment that would work, and I got 4504 to work, so that's odd. @kattni's changes are now available in https://github.com/kattni/Adafruit_CircuitPython_CircuitPlayground/tree/board-handling, so I tested with that, and also updated the other libs. |
|
@dhalbert OK sounds like this one needs to be closed up and a correct PR opened against the correct branch. Thanks for following up! I think the situation right now is that 4.x should be built with gcc7 and 5.x/master with gcc9, which could affect the results slightly. I am not sure now whether my build procedure locally would have been using gcc9 to build 4.x or not. If that is what happened, then it could explain the different results we each saw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports @dhalbert 's stack size change #2393 with a slightly larger value. Empirically, the 4504 value didn't work; the first value (a 512 byte bump) I tried did.
This, together with #2398 are probably prerequisites for @kattni 's work on fixing up the express library with cpx/cbp/cp functionality.