STM32: Allow simplex SPI #2459
Merged
STM32: Allow simplex SPI #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
suggested changes
Jan 8, 2020
|
Testing performed: On a feather stm32, I used a test program to exercise duplex, in-only, and out-only SPI. write, readinto, and write_readinto worked properly in each case where they should be applicable. I scoped clock and MOSI, and hooked MISO to GND and 3.3v to observe that correct values were input. I did notice that a short (.5us) pulse would occur on MOSI during SPI construction (or maybe activation via |
jepler
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the pin search algorithm to allow for the exclusion of MOSI or MISO on the SPI bus. Resolves #2309.
Tested for crashes and initializations, but unfortunately I don't have any SPI devices on hand with libraries that allow the exclusion of either pin, so that would be a beneficial extra test.