Update built-in help output for localization (Issue #3907) #3908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Dec 30, 2020
There was a problem hiding this comment.
This won't work because the type of a translate() is not a char *, it's a special compressed string type. You'll need to do more to get this to print. See calls to serial_write_compressed() in main.c, for example.
It would be good to test this in a local build.
|
Thank you for the feedback @dhalbert, much appreciated. Working on getting the build to complete locally. |
This reverts commit 23ed3ef.
Support localizing the output of a call to to match the firmware's language.
18e27f8 to
51b5299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding localization values for the output of calls to
help(<object>)can match the current firmware's language.This change addresses issue #3907