non-DMA SPI working; adding this now for testing; will continue with DMA #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Nov 16, 2017
| #include "hal/include/hal_spi_m_sync.h" | ||
| #include "hal/include/hpl_spi_m_sync.h" | ||
|
|
||
| #include "peripherals.h" |
There was a problem hiding this comment.
This change has two _peripherals.h files. Did you mean to merge them?
There was a problem hiding this comment.
Hi - peripherals.h includes either samd21_peripherals.h or samd51_peripherals.h. They are slightly different. Is that what you mean?
There was a problem hiding this comment.
I don't see peripherals.h in the diff.
There was a problem hiding this comment.
I added it in the previous PR when I did I2C. It hasn't changed: it's just conditional #includes.
|
Ah ok! You'll need to fix the build because CircuitPlayground is out of space. |
tannewt
previously approved these changes
Nov 17, 2017
Also, fixed pin mappings for rev B Metro M4: swap PA12 and PA13 on SPI 2x3 header swap A3 and A5 Comment out all frozen modules in CPX again to make room while waiting for SPI flash.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with BMP280 SPI on '21 and '51
needs corresponding ASF4 PR as well
Also, fixed pin mappings for rev B Metro M4:
swap PA12 and PA13 on SPI 2x3 header
swap A3 and A5
Comment out all frozen modules in CPX again to make room while waiting
for SPI flash.