ESP32 synthio channels to 12 #8189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Jul 24, 2023
|
fwiw the "significant resource use" is computation & RAM bandwidth |
|
Tested working on QTPy ESP32-S2 & QTPy ESP32-Pico via web workflow, and Lolin S2 Mini (ESP32-S2) via USB workflow. All report > 2MB free RAM via |
dhalbert
approved these changes
Jul 25, 2023
|
Will backport to 8.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed ESP32 boards have the default
CIRCUITPY_SYNTHIO_MAX_CHANNELSof 2.This puts it at 12, like RP2040 and others.
Tested on ESP32S3 QTPy and I2S DAC.