Skip to content

Build for feather huzzah on travis-ci #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2018
Merged

Build for feather huzzah on travis-ci #921

merged 2 commits into from
Jun 10, 2018

Conversation

jepler
Copy link

@jepler jepler commented Jun 10, 2018

My primary motivation is that in the recent past, it has occurred several times that the huzzah build has been broken for days before a developer discovers it themselves.

In jepler/esp-open-sdk, there is now a travis integration which uploads the toolchain to github. There's a release (which is just a date tag) with a toolchain attached that seems to work on trusty and on debian stretch. (it's built on trusty, same as circuitpython uses for its travis builds)

In this pull request, the travis integration fetches that toolchain and builds for feather_huzzah in addition to all the other boards.

@jepler
Copy link
Author

jepler commented Jun 10, 2018

Possible problems and concerns include:

  • The trust in the toolchain is attenuated a step or two further, by using more binary artifacts. This could be somewhat mitigated if adafruit forked esp-open-sdk, added my travis.yml, and used those binary artifacts instead of the ones from my fork.
  • The original author of the esp-open-sdk scripts expresses some concerns: "redistributability of this build is unclear". Everything that is source is under the general umbrella of redistributable code: MIT, BSD, and GPL. There are some binary files, but they are also marked as redistributable; they had better be, or distribution of finished images for huzzah boards would also be impermissible.
  • I can't actually test the produced binary for huzzah, since they just disappear into the ether.
  • I can't actually test that the changes to build_adafruit_bins.sh don't harm adafruit's internal release-making process, which does not use travis.

@tannewt tannewt self-requested a review June 10, 2018 20:42
tannewt
tannewt approved these changes Jun 10, 2018
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is amazing. I've been wishing for this forever.

We don't actually have an internal build process I just grab the artifacts off of our S3 bucket that Travis dumps them into.

@tannewt tannewt merged commit 83b0f62 into adafruit:master Jun 10, 2018
@jepler jepler deleted the travis-build-esp branch August 2, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @tannewt
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy