Skip to content

Implementation: Current Best Learning #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Implementation: Current Best Learning #591

wants to merge 9 commits into from

Conversation

antmarakis
Copy link
Collaborator

@antmarakis antmarakis commented Jul 21, 2017

Implemented the pseudocode from chapter 19, and added a testcase.

Since the learning module is getting a bit too large, I decided to create a new module (knowledge for the chapter title "Knowledge in Learning"). I feel like this is the best way to go, but I can change it if this is not appropriate. A few notes on the PR:

  • In the implementation I could have used the expression functionality we have already implemented, but after some quick testing the easiest way to go was a dictionary. I do plan though on converting the resulting hypothesis in my implementation into an Expr object in the future. Also, I am experimenting with another format for the hypothesis. It will take some time to settle though, since I want to see what the other algorithms in the chapter need. At least for now, I believe this will do.

  • The example I used (the restaurant example from the book) is taking too long to complete (between 5-15 seconds) due to the number of attributes. In the future (when I work on its notebook section) I will add new, simpler examples. I also added another, smaller example set.

  • I tried to make performance better, but the code was getting a bit too complicated, so I switched for the almost bruteforce-y way. I don't think that's an issue though, since students will rarely (if ever) encounter examples larger than the restaurant example, which at most takes about 20 seconds to complete, and that if the user is very unlucky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy