Skip to content

hid spinners for number input in firefox #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2016
Merged

hid spinners for number input in firefox #165

merged 1 commit into from
Jun 12, 2016

Conversation

jarettgross
Copy link
Contributor

Removed the spinners in Firefox in the number input for "interval". The spinners were covering part of the number before, so it always looked like 0 (rather than 0.1 or something else).

@64json 64json merged commit 8420110 into algorithm-visualizer:gh-pages Jun 12, 2016
@64json
Copy link
Member

64json commented Jun 12, 2016

Thanks, but don't forget to use gulp in order to automatically build public/algorithm_visualizer.css 😁

@jarettgross jarettgross deleted the hide-firefox-spinners branch June 12, 2016 16:17
@jarettgross
Copy link
Contributor Author

Similar issue as with my other commit -- when I built it with gulp there were about 15+ other files that were modified, even though I only touched this one file. I decided not to include those and only included my change. Should I commit all of the modified files, or just the file that I change?

@nem035
Copy link
Member

nem035 commented Jun 12, 2016

Hi @jarettgross, running gulp will rebuild all the files inside /public that were affected by your change. Meaning if you change css, it will rebuild the 2 css files in there, if you change any js, ti will rebuild the js files. Since files from /public are the ones actually included on the site, you need to rebuild them so the change can by applied.

64json added a commit that referenced this pull request Jul 24, 2018
@64json
Merge pull request #165 from jarettgross/hide-firefox-spinners
e297a8b 
hid spinners for number input in firefox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarettgross @64json @nem035
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy