Skip to content

Fullscreen #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2016
Merged

Fullscreen #172

merged 4 commits into from
Jun 12, 2016

Conversation

64json
Copy link
Member

@64json 64json commented Jun 12, 2016

No description provided.

EC2 Default User and others added 4 commits June 12, 2016 12:10
@64json 64json merged commit 2dee8c6 into gh-pages Jun 12, 2016
@64json 64json deleted the fullscreen branch June 12, 2016 14:32
@duaraghav8
Copy link
Member

awesome!

@64json
Copy link
Member Author

64json commented Jun 12, 2016

@duaraghav8 Thanks for your great idea 😁

@duaraghav8
Copy link
Member

duaraghav8 commented Jun 12, 2016

Inspired from Hackerrank :P
Could you please tell me why you chose to instead hard-code the vendor-specific functions in the updated enable_fullscreen.js?
Is this choice due to speed? (because my reasoning was that the code could be space-wise efficient if we didn't hard-code)

@64json
Copy link
Member Author

64json commented Jun 12, 2016

@duaraghav8
There may not be so much difference in speed though, I found out that some of the function names are {prefix}FullScreen and others are {prefix}Fullscreen, which is crappy 😂.

@duaraghav8
Copy link
Member

yea that was a facepalm moment for me too

64json added a commit that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy