Skip to content

build: migrate partial compliance tests to rules_js #61865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

build: migrate partial compliance tests to rules_js #61865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f10a08c
build: introduce NodeJS loader for `rules_js` Node execution
devversion Jun 4, 2025
a4f09e7
build: migrate partial compliance tests to `rules_js`
devversion Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
adev/shared-docs/pipeline/api-gen/package.json=939673974
integration/package.json=-239561259
modules/package.json=-1315257891
package.json=1012566638
package.json=-1124738082
packages/animations/package.json=-678724831
packages/common/package.json=1729763064
packages/compiler-cli/linker/babel/test/package.json=939673974
Expand All @@ -21,7 +21,7 @@ packages/platform-browser/package.json=-1163479450
packages/router/package.json=860819913
packages/upgrade/package.json=16347051
packages/zone.js/package.json=-1577512523
pnpm-lock.yaml=-1427965318
pnpm-lock.yaml=1622469731
pnpm-workspace.yaml=1973735808
tools/bazel/rules_angular_store/package.json=-239561259
yarn.lock=-1301634010
yarn.lock=916728416
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@
"emoji-regex": "^10.3.0",
"fflate": "^0.8.2",
"firebase-tools": "^14.0.0",
"get-tsconfig": "^4.10.1",
"gulp": "^5.0.0",
"gulp-conventional-changelog": "^5.0.0",
"html-entities": "^2.5.2",
Expand Down
40 changes: 19 additions & 21 deletions packages/compiler-cli/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,32 +82,30 @@ ts_project(
"src/integrationtest/**/*.ts",
],
),
interop_deps = [
"//packages/compiler",
"//packages/compiler-cli/private",
"//packages/compiler-cli/src/ngtsc/core",
"//packages/compiler-cli/src/ngtsc/core:api",
"//packages/compiler-cli/src/ngtsc/diagnostics",
"//packages/compiler-cli/src/ngtsc/docs",
"//packages/compiler-cli/src/ngtsc/file_system",
"//packages/compiler-cli/src/ngtsc/incremental",
"//packages/compiler-cli/src/ngtsc/indexer",
"//packages/compiler-cli/src/ngtsc/logging",
"//packages/compiler-cli/src/ngtsc/perf",
"//packages/compiler-cli/src/ngtsc/program_driver",
"//packages/compiler-cli/src/ngtsc/reflection",
"//packages/compiler-cli/src/ngtsc/shims",
"//packages/compiler-cli/src/ngtsc/transform/jit",
"//packages/compiler-cli/src/ngtsc/translator",
"//packages/compiler-cli/src/ngtsc/typecheck",
"//packages/compiler-cli/src/ngtsc/typecheck/api",
"//packages/compiler-cli/src/ngtsc/util",
],
deps = [
"//:node_modules/@types/yargs",
"//:node_modules/chokidar",
"//:node_modules/reflect-metadata",
"//:node_modules/typescript",
"//packages/compiler:compiler_rjs",
"//packages/compiler-cli/private:private_rjs",
"//packages/compiler-cli/src/ngtsc/core:api_rjs",
"//packages/compiler-cli/src/ngtsc/core:core_rjs",
"//packages/compiler-cli/src/ngtsc/diagnostics:diagnostics_rjs",
"//packages/compiler-cli/src/ngtsc/docs:docs_rjs",
"//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
"//packages/compiler-cli/src/ngtsc/incremental:incremental_rjs",
"//packages/compiler-cli/src/ngtsc/indexer:indexer_rjs",
"//packages/compiler-cli/src/ngtsc/logging:logging_rjs",
"//packages/compiler-cli/src/ngtsc/perf:perf_rjs",
"//packages/compiler-cli/src/ngtsc/program_driver:program_driver_rjs",
"//packages/compiler-cli/src/ngtsc/reflection:reflection_rjs",
"//packages/compiler-cli/src/ngtsc/shims:shims_rjs",
"//packages/compiler-cli/src/ngtsc/transform/jit:jit_rjs",
"//packages/compiler-cli/src/ngtsc/translator:translator_rjs",
"//packages/compiler-cli/src/ngtsc/typecheck:typecheck_rjs",
"//packages/compiler-cli/src/ngtsc/typecheck/api:api_rjs",
"//packages/compiler-cli/src/ngtsc/util:util_rjs",
],
)

Expand Down
8 changes: 4 additions & 4 deletions packages/compiler-cli/test/compliance/partial/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ ts_project(
"cli.ts",
"generate_golden_partial.ts",
],
interop_deps = [
"//packages/compiler-cli/src/ngtsc/file_system",
"//packages/compiler-cli/test/compliance/test_helpers",
],
visibility = ["//packages/compiler-cli/test/compliance:__subpackages__"],
deps = [
"//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
"//packages/compiler-cli/test/compliance/test_helpers:test_helpers_rjs",
],
)

exports_files([
Expand Down
33 changes: 10 additions & 23 deletions packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
load("@aspect_rules_js//js:defs.bzl", "js_run_binary")
load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
load("//tools:defaults.bzl", "nodejs_binary", "npm_package_bin")
load("//tools/bazel:js_binary.bzl", "js_binary")

def partial_compliance_golden(filePath):
"""Creates the generate and testing targets for partial compile results.
Expand All @@ -9,50 +10,36 @@ def partial_compliance_golden(filePath):
path = filePath[:-len("/TEST_CASES.json")]
generate_partial_name = "partial_%s" % path
data = [
"//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib",
"//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib_rjs",
"//packages/core:npm_package",
"//packages:package_json",
filePath,
] + native.glob(["%s/*.ts" % path, "%s/**/*.html" % path, "%s/**/*.css" % path])

nodejs_binary(
js_binary(
name = generate_partial_name,
testonly = True,
data = data,
visibility = [":__pkg__"],
entry_point = "//packages/compiler-cli/test/compliance/partial:cli.js",
templated_args = ["$(execpath %s)" % filePath],
fixed_args = ["$(rootpath %s)" % filePath],
)

nodejs_binary(
name = generate_partial_name + ".debug",
testonly = True,
data = data,
visibility = [":__pkg__"],
entry_point = "//packages/compiler-cli/test/compliance/partial:cli.js",
templated_args = ["--node_options=--inspect-brk", filePath],
)

npm_package_bin(
js_run_binary(
name = "_generated_%s" % path,
tool = generate_partial_name,
testonly = True,
outs = ["%s/_generated.js" % path],
link_workspace_root = True,
# Disable the linker and rely on patched resolution which works better on Windows
# and is less prone to race conditions when targets build concurrently.
args = ["--nobazel_run_linker", "$@"],
# Relativize execpath to be relative to bazel-bin (bazel-out/k8-fastbuild/bin).
args = ["../../../$(@)"],
visibility = [":__pkg__"],
# TODO(devversion): re-enable when we figure out the RBE hanging process issue.
tags = ["no-remote-exec"],
data = [],
mnemonic = "GeneratePartialGolden",
progress_message = "Generating partial golden: %{label}",
)

generated_file_test(
visibility = ["//visibility:public"],
name = "%s.golden" % path,
src = "//packages/compiler-cli/test/compliance/test_cases:%s/GOLDEN_PARTIAL.js" % path,
# TODO(devversion): re-enable when we figure out the RBE hanging process issue.
tags = ["no-remote-exec"],
generated = "_generated_%s" % path,
)
18 changes: 8 additions & 10 deletions packages/compiler-cli/test/compliance/test_helpers/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,19 @@ ts_project(
srcs = glob(
["**/*.ts"],
),
interop_deps = [
"//packages:types",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/compiler-cli/src/ngtsc/file_system",
"//packages/compiler-cli/src/ngtsc/file_system/testing",
"//packages/compiler-cli/src/ngtsc/logging",
"//packages/compiler-cli/src/ngtsc/sourcemaps",
"//packages/compiler-cli/src/ngtsc/testing",
],
visibility = [
"//packages/compiler-cli/test/compliance:__subpackages__",
],
deps = [
"//:node_modules/@bazel/runfiles",
"//:node_modules/typescript",
"//packages:types",
"//packages/compiler:compiler_rjs",
"//packages/compiler-cli:compiler-cli_rjs",
"//packages/compiler-cli/src/ngtsc/file_system:file_system_rjs",
"//packages/compiler-cli/src/ngtsc/file_system/testing:testing_rjs",
"//packages/compiler-cli/src/ngtsc/logging:logging_rjs",
"//packages/compiler-cli/src/ngtsc/sourcemaps:sourcemaps_rjs",
"//packages/compiler-cli/src/ngtsc/testing:testing_rjs",
],
)
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy