-
Notifications
You must be signed in to change notification settings - Fork 26.4k
refactor(core): Delete createSignalTuple #61907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: primitives-shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reviewed-for: primitives, fw-general, public-api
TESTED=TGP |
TGP is green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: fw-general
Reviewed-for: public-api
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior. PR Close #61907
This PR was merged into the repository by commit 6097184. The changes were merged into the following branches: main, 20.0.x |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
It removes createSignalTuple because it is no longer needed.
What is the current behavior?
createSignalTuple was a deprecated API
Issue Number: N/A
What is the new behavior?
createSignalTuple is removed
Does this PR introduce a breaking change?
Other information