Skip to content

refactor(core): Delete createSignalTuple #61907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tsc036
Copy link
Contributor

@tsc036 tsc036 commented Jun 5, 2025

Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
It removes createSignalTuple because it is no longer needed.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

createSignalTuple was a deprecated API

Issue Number: N/A

What is the new behavior?

createSignalTuple is removed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.
@pullapprove pullapprove bot requested review from atscott and mturco June 5, 2025 17:33
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 5, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 5, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 5, 2025
Copy link
Contributor

@mturco mturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: primitives-shared

Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: primitives, fw-general, public-api

@thePunderWoman thePunderWoman removed the request for review from atscott June 6, 2025 07:32
@thePunderWoman
Copy link
Contributor

TESTED=TGP

@thePunderWoman
Copy link
Contributor

TGP is green

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 6, 2025
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-general
Reviewed-for: public-api

pkozlowski-opensource pushed a commit that referenced this pull request Jun 6, 2025
Delete createSignalTuple because it is no longer needed. creatSignal has the same behavior.

PR Close #61907
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 6097184.

The changes were merged into the following branches: main, 20.0.x

@tsc036 tsc036 deleted the remove-create-signal-tuple branch June 9, 2025 16:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy