fix(devtools): implement signal read error handling in DevTools #61911
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: angular#61900 Previously in DevTools we would read signal values to display preview values in the UI without safely catching any errors thrown in their evaluations. Now those signal functions are run in a safe context, their errors are caught and handled in the UI as well as replayed in the console.
00e1d61 to
8658bc3
Compare
JeanMeche
reviewed
Jun 5, 2025
| const value = signal(); | ||
| return {error: undefined, value}; | ||
| } catch (error) { | ||
| console.error('[Angular DevTools]: Error reading signal value:', error); |
There was a problem hiding this comment.
As @dgp1130 mentionned recently, we should probably start having a better logging strategy to not polute the browsers console. WDYT ?
There was a problem hiding this comment.
I'm more ok with user-meaningful errors like this, rather than noise about internal work going on. But ideally the error would be reported in the UI directly rather than directing users to the console.
I probably wouldn't block on that, as printing a nicer error to the console is better than what we have today. I'd probably think of it as an opportunity to improve this later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61900
Previously in DevTools we would read signal values to display preview values in the UI without safely catching any errors thrown in their evaluations.
Now those signal functions are run in a safe context, their errors are caught and handled in the UI as well as replayed in the console.