Skip to content

docs (docs-infra): add tooltip and snackbar for copied #62460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs (docs-infra): add tooltip and snackbar for copied #62460

wants to merge 1 commit into from

Conversation

akib1997
Copy link
Contributor

@akib1997 akib1997 commented Jul 3, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No tooltip on example code block

Issue Number: N/A

What is the new behavior?

a tooltip on hover: "Copy code"
a Copied message after clicking

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from kirjs July 3, 2025 19:55
@JeanMeche JeanMeche requested review from JeanMeche and removed request for kirjs July 3, 2025 20:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

Deployed adev-preview for 68562f0 to: https://ng-dev-previews-fw--pr-angular-angular-62460-adev-prev-00q6azui.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@thePunderWoman
Copy link
Contributor

@akib1997 Could you please fixup your PR commit message? You keep putting a space between docs and (docs-infra), which will cause lint to fail. Make sure it's docs(docs-infra): message here.

@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release area: docs-infra Angular.dev application and infrastructure area: docs Related to the documentation labels Jul 7, 2025
@ngbot ngbot bot modified the milestone: Backlog Jul 7, 2025
@akib1997 akib1997 force-pushed the refactor/docs-viewer branch from 58f9431 to 348d390 Compare July 7, 2025 20:56
@JeanMeche
Copy link
Member

JeanMeche commented Jul 9, 2025 •
edited
Loading

The code also needs reformating.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 11, 2025
@thePunderWoman
Copy link
Contributor

@akib1997 There's some consistently failing adev tests. Can you take a look?

@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jul 11, 2025
@akib1997 akib1997 force-pushed the refactor/docs-viewer branch from 9235cab to 2d7d7f1 Compare July 11, 2025 19:37
@pullapprove pullapprove bot requested a review from josephperrott July 11, 2025 19:38
@angular-robot angular-robot bot requested a review from JeanMeche July 11, 2025 19:38
@akib1997 akib1997 closed this Jul 11, 2025
@akib1997 akib1997 force-pushed the refactor/docs-viewer branch from 2d7d7f1 to bece163 Compare July 11, 2025 19:44
@akib1997 akib1997 reopened this Jul 11, 2025
@JeanMeche
Copy link
Member

Looks like the change also broke a unit test. Can you please have a look. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott Awaiting requested review from josephperrott

@JeanMeche JeanMeche Awaiting requested review from JeanMeche

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@akib1997 @thePunderWoman @JeanMeche
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy