feat(language-service): support auto-import for attribute completions #62797
+295
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20ecdc5 to
286e034
Compare
ivanwonder
commented
Jul 25, 2025
| ); | ||
| if (info === null) { | ||
| return undefined; | ||
| break; |
There was a problem hiding this comment.
I think it's better to use break than return. After the switch statement, there is logic for the code action.
There was a problem hiding this comment.
For example, there is a bug in the function getTsSymbolDisplayInfo; if the symbol is a "get" accessor declaration, the function returns null, which causes the logic of the code action to be skipped.
| @@ -831,8 +831,7 @@ describe('completions', () => { | |||
| expect(ts.displayPartsToString(details.documentation!)).toEqual('This is another component.'); | |||
| }); | |||
|
|
|||
| // TODO: check why this test is now broken | |||
There was a problem hiding this comment.
Broken because the completion item for the attribute only includes the directive in the component scope.
Add logic to provide code actions for auto-importing directives that are out of scope.
286e034 to
451f83f
Compare
|
@atscott PTAL |
attribute-completion.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to provide code actions for auto-importing directives that
are out of scope.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information