Skip to content

refactor(signal-forms): remove unsubmitted and submitted field states #62812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

leonsenft
Copy link
Contributor

  • FieldState.submittedStatus is replaced by FieldState.submitting, which tracks only whether the form is currently being submitted. This state is propagated downwards to all descendants of the submitted field.

  • submit() now marks the field and all of its descendants as touched to ensure that any validation errors are displayed upon submission attempts.

@ngbot ngbot bot added this to the Backlog milestone Jul 29, 2025
@angular-robot angular-robot bot added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Jul 29, 2025
@leonsenft leonsenft force-pushed the submit branch 2 times, most recently from fadaab9 to 3b2383a Compare July 30, 2025 17:28
* `FieldState.submittedStatus` is replaced by `FieldState.submitting`,
  which tracks only whether the form is currently being submitted. This
  state is propagated downwards to all descendants of the submitted field.

* `submit()` now marks the field and all of its descendants as touched
  to ensure that any validation errors are displayed upon submission
  attempts.
@leonsenft leonsenft merged commit 5747c7a into angular:prototype/signal-forms Jul 30, 2025
14 of 16 checks passed
@leonsenft leonsenft deleted the submit branch July 30, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy