Skip to content

fix(@angular/cli): skip workspace-specific tools when outside a workspace #30795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 28, 2025

When the MCP server is initialized outside of an Angular workspace, workspace-specific tools such as list_projects should not be registered as they will not function correctly.

…pace

When the MCP server is initialized outside of an Angular workspace, workspace-specific tools such as  should not be registered as they will not function correctly.
@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 28, 2025
@clydin clydin requested a review from alan-agius4 July 28, 2025 16:21
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 29, 2025
@clydin clydin merged commit 193b394 into angular:main Jul 29, 2025
33 of 34 checks passed
@clydin
Copy link
Member Author

clydin commented Jul 29, 2025

The changes were merged into the following branches: main, 20.1.x

@clydin clydin deleted the mcp/workspace-specific-tools branch July 29, 2025 14:03

// If run outside an Angular workspace (e.g., globally) skip the workspace specific tools.
// Currently only the `list_projects` tool.
if (!context.workspace) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this condition reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy