Skip to content

test(@angular/cli): add initial e2e test for MCP server tool registration #30803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 30, 2025

Introduces the first end-to-end test for the MCP server. The new test, registers-tools.ts, verifies that the MCP server correctly initializes and registers its default set of tools. This provides a foundation for more comprehensive e2e testing of the MCP server and its features.

@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 30, 2025
@clydin clydin force-pushed the mcp/initial-e2e-tests branch from 02653ec to 6423c66 Compare July 30, 2025 17:38
@clydin clydin requested a review from dgp1130 July 30, 2025 18:32
'--no',
'@angular/cli',
'mcp',
...args,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: How is npx pulling in the locally built version of the CLI? Is this going through Verdaccio through an .npmrc configuration or something like that?

I'm wondering if there's a more direct implementation through something like: mcp-inspector-cli --cli node_modules/.bin/ng mcp ...args?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx uses the locally installed version if present, then the global. If neither are present, it then tries to download from the registry. However, the --no option prevents that last step. The package should always be present so the failure with the --no option effectively acts as an assertion for the test setup.
The arguments are based on the recommended usage/configuration as well to better represent real world use.

…tion

Introduces the first end-to-end test for the MCP server. The new test, `registers-tools.ts`, verifies that the MCP server correctly initializes and registers its default set of tools.
This provides a foundation for more comprehensive e2e testing of the MCP server and its features.
@clydin clydin force-pushed the mcp/initial-e2e-tests branch from 6423c66 to 469ff77 Compare August 1, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: @angular/cli target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy