refactor(ngMock window.inject test): comment on important function wr…

…apper usage Explicitly commented on why we use an extra function wrapper around the test inject Error throwing code, and how not using it would make our tests give us false positives on certain browsers, e.g. Firefox.
angular · jurko-gospodnetic · Dec 20, 2015 · Dec 20, 2015 · Dec 20, 2015 · Dec 20, 2015
commit 4e78a7f9dd027de6a7976f2b605aaf794b7e3446
diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js
@@ -934,6 +934,9 @@ describe('ngMock', function() {
       // call in multiple test specs
       function testInjectCaller() {
         var shouldThrow;
+        // using an extra internalInjectCaller() wrapper here avoids stack trace
+        // constructed by some browsers (e.g. FireFox) from containing the name
+        // of the external caller function
         var injectingCall = (function internalInjectCaller() {
           return inject(function() {
             if (shouldThrow)