Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(injector): make sure we call Function.prototype.toString not an override #14361

Closed
wants to merge 3 commits into from
Closed

fix(injector): make sure we call Function.prototype.toString not an override #14361

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b2dbd
refactor(injector): make sure we call Function.prototype.toString not…
Apr 1, 2016
c00cc16
test(injector): make sure annotate can handle functions with overridd…
Apr 6, 2016
a188c47
style(injector): remove unnecessary whitespaces
Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(injector): make sure we call Function.prototype.toString not… 
… an override

use Function.prototype.toString.call instead of fn.toString, because the user might override the toString function of the "fn" instance, without knowing it's being used by the injector.
  • Loading branch information
a510 committed Apr 1, 2016
commit 28b2dbd1d293f1a0781f889e2d41fda2dc6f57c0
2 changes: 1 addition & 1 deletion src/auto/injector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ var STRIP_COMMENTS = /((\/\/.*$)|(\/\*[\s\S]*?\*\/))/mg;
var $injectorMinErr = minErr('$injector');

function extractArgs(fn) {
var fnText = fn.toString().replace(STRIP_COMMENTS, ''),
var fnText = Function.prototype.toString.call(fn).replace(STRIP_COMMENTS, ''),
args = fnText.match(ARROW_ARG) || fnText.match(FN_ARGS);
return args;
}
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy