-
Notifications
You must be signed in to change notification settings - Fork 27.3k
Remove duplicate $digest() #8840
Conversation
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I'm not sure why it's talking about "digest" and "events" in the same sentence at all. Those are probably supposed to be talking about |
/cc @petebacondarwin (this was you 4a6a3ba) |
@caitp - actually all my commit changed was the link. |
Actually I'm wrong, that comment goes back a lot further than that commit :x -- yeah, that line has changed a few times, but the intent of the line never seems to have been questioned, it goes back a few years |
Here we go, looks like it was this: 42062da --- I guess we used to have $flush and $digest. Yeah this looks right, just remove the second $digest and it makes sense. |
Anyways yeah, lgtm --- just surprised it took so long to be corrected :p I'm still not sure why we're calling it an "event", but I guess it works |
caitp - should I close this and open a new pull request with $flush and $digest? |
no, $flush was removed years ago --- I'm merging this, just fixing the trailing whitespace first |
Cool, thanks |
Seems like the same event was added twice on accident. Perhaps something else was meant in place of the second $digest() but as it stands it is confusing.