fix(eslint-plugin-template): [no-interpolation-in-attributes] use keySpan as attr. range and sourceSpan as replacement range #2531
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 64c5135.
☁️ Nx Cloud last updated this comment at |
…Span as attr. range and sourceSpan as replacement range
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 92.79% 92.80%
=======================================
Files 207 207
Lines 4374 4379 +5
Branches 1020 1020
=======================================
+ Hits 4059 4064 +5
Misses 245 245
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JamesHenry
approved these changes
Jun 19, 2025
JamesHenry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…Span as attr. range and sourceSpan as replacement range (#2531)
|
Thanks @niwolf as a special exception to my usual policy, I backported this one as |
|
Thank you very much! @JamesHenry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for released version 19.8: #2501
This PR fixes an issue in the no-interpolation-in-attributes rule where attributes using attr. (e.g.
attr.data-*) were incorrectly autofixed by removing the attr. prefix. The fixer now correctly preserves the full attribute name, ensuring proper binding syntax like[attr.data-example]="...".If this fix is valid, I'd appreciate it if it could still be included in a v19 release, if possible.