Skip to content

add dag_run_ids and task_ids filter for the batch task instance API endpoint #32705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2023
Merged

add dag_run_ids and task_ids filter for the batch task instance API endpoint #32705

merged 3 commits into from
Aug 7, 2023

Conversation

karakanb
Copy link
Contributor

This PR introduces two new filters for the batch task instance endpoint:

  • dag_run_ids: a set of DAG Run IDs to filter the instances that were in those runs
  • task_ids: a set of task IDs that the instances were for

Let me know if you have any feedback.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 19, 2023
@uranusjr
Copy link
Member

Can you add “New in version” markers to the parameters in the OpenAPI spec please? There are various examples if you search in the file.

@karakanb
Copy link
Contributor Author

@uranusjr done, assumed it'd go in 2.6.4, please take a look.

@eladkal eladkal added this to the Airflow 2.7.0 milestone Aug 1, 2023
@karakanb
Copy link
Contributor Author

karakanb commented Aug 3, 2023

not sure if maintainers can do that right away but please feel free to modify any files here before you merge as you see fit, e.g. fixing the version. if you let me know what'd be the right version number I can also do that.

@potiuk
Copy link
Member

potiuk commented Aug 3, 2023

I think will hold-off with those merges for a short while due to cutting out 2.7.0 release, but I think @pierrejeambrun looked at the open-api changes recently :)

pierrejeambrun
pierrejeambrun reviewed Aug 5, 2023
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me and working as expected. As mentioned 2.7.0 is already being cut out and this will most probably go into 2.7.1 can you please update the New in version xxxx part, and we should be good to go :)

edit: I just updated it.

Approved

@potiuk potiuk merged commit 08b1e8d into apache:main Aug 7, 2023
ephraimbuddy pushed a commit that referenced this pull request Aug 8, 2023
@karakanb @pierrejeambrun @ephraimbuddy
add dag_run_ids and task_ids filter for the batch task instance API e…
699fba3 
…ndpoint (#32705)

* add dag_run_ids and task_ids as filter types for the batch task instance endpoint

* add version notice to the new filters

* Update the released version in OpenAPI spec

---------

Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
(cherry picked from commit 08b1e8d)
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr uranusjr approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@ashb ashb Awaiting requested review from ashb

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@karakanb @uranusjr @potiuk @pierrejeambrun @ephraimbuddy @eladkal
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy