Fix OpenAPI schema for get_log API
#50547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @guan404ming for raising this issue during our offline discussion. |
|
Lightning speed ⚡️ Thanks for the PR. |
pierrejeambrun
approved these changes
May 13, 2025
There was a problem hiding this comment.
Looks good thanks.
I guess we need to wait for #49470 before merging.
83e53e9 to
9217985
Compare
This PR does not depend on #49470 (the log reading refactor). |
bugraoz93
approved these changes
May 14, 2025
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 3, 2025
* Fix openapi schema for get_log API * Fix test_log (cherry picked from commit 08cc57d)
|
Backport pr #51357 |
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…50746) (#51202) * Fix OpenAPI schema for `get_log` API (#50547) * Fix openapi schema for get_log API * Fix test_log (cherry picked from commit 08cc57d) * [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746) * Update TaskLogContent to support virtualized rendering * Update TaskLogPreview and Logs to handle undefined parsedLogs (cherry picked from commit 813f3e3) Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com> --------- Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…50746) (#51202) * Fix OpenAPI schema for `get_log` API (#50547) * Fix openapi schema for get_log API * Fix test_log (cherry picked from commit 08cc57d) * [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746) * Update TaskLogContent to support virtualized rendering * Update TaskLogPreview and Logs to handle undefined parsedLogs (cherry picked from commit 813f3e3) Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com> --------- Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Fix openapi schema for get_log API * Fix test_log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #50333, #49470
Why
The #50333 PR require the
Content-Typeto beapplication/x-ndjsonfor theget_logendpoint to generate correct frontend query.airflow/airflow-core/src/airflow/ui/openapi-gen/queries/queries.ts
Line 770 in 51a84ce
What
Since PR #46827 sets the
Content-Typetoapplication/x-ndjson, this change explicitly aligns with that behavior by usingapplication/x-ndjsonto ensure consistency and correctness:https://github.com/apache/airflow/pull/46827/files#diff-18e153220119c0579d8b8030d13daaa04a623b38f9854ffff8702a2bbe68f4f8R123-R130