Skip to content

Add generated python client #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Add generated python client #1

merged 4 commits into from
Mar 18, 2021

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Mar 18, 2021

No description provided.

@msumit msumit merged commit 086851a into apache:master Mar 18, 2021
@houqp
Copy link
Member

houqp commented Mar 18, 2021

I recommend us go with hosting the generated code in a sub module instead so we can have more control over the client. For example, we can add our own extension code for new auth methods etc. That way, we will also be able to manage our own user friendly readme. The generated README is too dense for onboarding purpose.

Here is an example on how k8s manages their generated python client in submodules: https://github.com/kubernetes-client/python. Airflow's go client took the same approach as well.

@msumit
Copy link
Contributor Author

msumit commented Mar 19, 2021

@houqp yeah, even I thought the same but didn't bother to do that as it was the first code push in this repo. Raised #2 for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy