Skip to content

Rebuild with airflow 2.4.2 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2022
Merged

Rebuild with airflow 2.4.2 #51

merged 2 commits into from
Nov 15, 2022

Conversation

csm10495
Copy link
Contributor

@csm10495 csm10495 commented Nov 2, 2022

I'm not really sure the right way to do this but this is a rebuild of this library based off the code of the recently released Airflow 2.4.2. It would be really cool if on each airflow release this got rebuilt and released up to pypi. How do releases normally work?

I basically got airflow cloned down next to airflow-client-python. Checked out 2.4.2 of airflow. Checked out the latest for airflow-client-python. Went in airflow's v1.yaml file, ensured we had:

security:
  - Basic: []
  - GoogleOpenId: []
  - Kerberos: []

Then i went to the airflow-client-python directory and ran:

./clients/gen/python.sh airflow/api_connexion/openapi/v1.yaml ../airflow-client-python/airflow_client

added the changes via git then ran:

pre-commit run --all-files

added those changes and made this commit / PR here.

@potiuk potiuk requested a review from msumit November 7, 2022 01:52
@potiuk
Copy link
Member

potiuk commented Nov 7, 2022

I believe this is correct way of doing it. And possibly @msumit can shed some light on the release process here :).

@csm10495
Copy link
Contributor Author

@msumit / @potiuk , any chance for some guidance or a merge here?

2.4.3 is coming soon... after that it would be nice to do this again for 2.4.3 :)

@csm10495 csm10495 mentioned this pull request Nov 14, 2022
Merged
@msumit
Copy link
Contributor

msumit commented Nov 14, 2022

@csm10495 @potiuk taking a look..

@msumit
Copy link
Contributor

msumit commented Nov 14, 2022

@csm10495 overall looks ok, but we'll also need to update the version in setup.py file (plz document this piece as well :) ).. Another imp point to note that for client we take only Airflow's major & minor version and patch version is internal to client itself.. So for example all Airflow releases for 2.4.X would have the same client version 2.4.0, as we assume that there won't be any new API going to be added in a Airflow patch release. So in short, we won't be release another client version until Airlfow 2.5.X is out.

@msumit
Copy link
Contributor

msumit commented Nov 14, 2022

And once this PR gets merged, just follow the release process documented here.

@csm10495
Copy link
Contributor Author

@msumit I'm not sure the .X for patch version is really valid though since there could be bugfixes, etc that get into airflow that we may want ported over to clients. I'll update README.md to match what you've said since that is defacto the case for now. Related chatter: apache/airflow#27670

@csm10495
Copy link
Contributor Author

Done. @msumit check again. Even after merge i don't have permissions to do the release part.

@msumit msumit merged commit 3547adf into apache:master Nov 15, 2022
@msumit
Copy link
Contributor

msumit commented Nov 15, 2022

@csm10495 I've merged the PR, For release, you would need access to svn repo etc, I hope @potiuk can help you to get those (not sure though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msumit msumit msumit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csm10495 @potiuk @msumit
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy