drivers/usbhost: Update usbhost_hidkbd.c #15917
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were messing quotes for key "backspace" for scancodes. It caused an error in cmake. Maybe I'm doing something wrong because I never used an embedded system before, but I still wanted to share it. \177 -> '\177'
|
Hi @StagiaireAbritek thank you for this fix! |
acassis
approved these changes
Feb 27, 2025
jerpelea
requested changes
Feb 28, 2025
simbit18
approved these changes
Feb 28, 2025
|
@StagiaireAbritek please run: ./tools/checkpatch.sh -f drivers/usbhost/usbhost_hidkbd.c, seems like when you added ' ' it displaced the comments aligment |
|
Hey @StagiaireAbritek are you around? Do you need help to make your patch pass in the github CI ? |
|
@StagiaireAbritek ping! Please fix the issue "Wrong column position of comment right of code" at line 620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ESP32-S3
There were missing quotes for key "backspace" for scancodes. It caused an error in cmake. Maybe I'm doing something wrong because I never used an embedded system before, but I still wanted to share it. \177 -> '\177'. USB_ALLSCANCODES
Impact
Only only occurs when the config option all scan codes is enabled for hid devices. It prevents from doing the command make to deploy nuttx. (Sorry this is my first time doing C I don't know the terms)
Testing
BEFORE :
Register: nsh
Register: sh
CC: usbhost/usbhost_hidkbd.c usbhost/usbhost_hidkbd.c:620:26: error: stray '' in program
620 | '{', '}', '\t', \177, 'A', 'B', 'C', 'D', /* 0xb8-0xbf: {,},tab,backspace,A-D */
| ^
make[1]: *** [Makefile:109: usbhost_hidkbd.o] Error 1
make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
AFTER:
no error